Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dragon Slayer spell selection for the AI #9618

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Mar 9, 2025

close #8707

@ihhub ihhub added improvement New feature, request or improvement AI Artificial intelligence behaviour labels Mar 9, 2025
@ihhub ihhub added this to the 1.1.7 milestone Mar 9, 2025
@ihhub ihhub self-assigned this Mar 9, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, everything looks good (I just made another variable const). But I'm not too good at spell evaluation methods.

@ihhub
Copy link
Owner Author

ihhub commented Mar 10, 2025

Hi @idshibanov , could you please review this PR as well as you were the one implementing the core logic for spell evaluation?

Co-authored-by: Oleg Derevenetz <oleg-derevenetz@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Artificial intelligence behaviour improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic to correctly evaluate Dragon Slayer spell for AI
3 participants